Subpixel mouse events #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
force-pushed
the
Subpixel-mouse-events
branch
from
8c753aa to
2b7a7c0
Compare
Member
|
What if we set the box size to 2px, will the click be on |
Contributor
Author
x and y are numbers (not integers) according to the spec. So I think it is best to just support them. Initially I thought making them floats internally as well and have the renderer deal with the conversion, but the DOM also expects integers, so I think it is best to just convert them immediately. |
krichprollsch
approved these changes
May 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mouse events can be in the middle of a pixel
{x: 1.5, y: 0.5}NetSurf Dom or our rendered do not support that and just need the pixel where the event happened so we convert it to an integer when we get the value.