Skip to content

Mouse event fixes #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2025
Merged

Mouse event fixes #603

merged 6 commits into from
May 9, 2025

Conversation

@sjorsdonkers
Copy link
Contributor

@sjorsdonkers sjorsdonkers commented May 6, 2025 •
edited
Loading

Several issues prevents MouserPressed commands from working:

  • URL buffer of 1kb resulted in OutOfMemory error for puppeteer click.js
  • of by 1 errors in renderer's pixel location -> rendered now starts at x=0 instead of x=1
  • Delay navigation as otherwise the dom tree was deleted during the event causing a crash

sjorsdonkers
sjorsdonkers commented May 7, 2025
View reviewed changes
@sjorsdonkers sjorsdonkers marked this pull request as ready for review May 7, 2025 12:38
krichprollsch
krichprollsch approved these changes May 8, 2025
View reviewed changes
@sjorsdonkers sjorsdonkers merged commit 1820e79 into main May 9, 2025
12 checks passed
@sjorsdonkers sjorsdonkers deleted the mouseevents branch May 9, 2025 08:44
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krichprollsch krichprollsch krichprollsch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjorsdonkers @krichprollsch