Skip to content

Page Module Map #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Page Module Map #632

merged 1 commit into from
May 13, 2025

Conversation

@mookums
Copy link
Contributor

@mookums mookums commented May 12, 2025

This adds a module_map to the Page that prevents circular dependencies from entering a fetch loop. It uses the full path (obtained with the URL.stitch) as the key.

karlseguin
karlseguin reviewed May 13, 2025
View reviewed changes
@karlseguin karlseguin merged commit c3a992e into main May 13, 2025
9 checks passed
@karlseguin karlseguin deleted the module-map branch May 13, 2025 13:46
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karlseguin karlseguin karlseguin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mookums @karlseguin