implementation: remove the setTitle method call #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libdom uses the doc's body and title attributes by default. But it fallback to the DOM tree if the attributes are NULL. I think it's better to have only the DOM tree set on document creation.
| _ = try nodeAppendChild(elementToNode(html), elementToNode(head)); | ||
|
|
||
| if (title) |t| { | ||
| try documentHTMLSetTitle(doc_html, t); |
Contributor
There was a problem hiding this comment.
Seems it would be more performant if we do set it as it would not have to search for it here.
If we keep it, it would be good to comment why it is there.
Member
Author
There was a problem hiding this comment.
documentCreateDocument calls already documentHTMLSetTitle. But moving this tree creation to documentCreateDocument will be clearer.
sjorsdonkers
approved these changes
May 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libdom uses the doc's body and title attributes by default. But it fallback to the DOM tree if the attributes are NULL.
I think it's better to have only the DOM tree set on document creation.