Do not getComputedStyle #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
force-pushed
the
do-not-getComputedStyle
branch
from
ae630ea to
9e32661
Compare
krichprollsch
approved these changes
May 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get playwright/click.js to work this "implementation" is sufficient.
getComputedStyle is a relatively large feature: https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle
It is also likely touches rendering, as such it may be better for us to kick this down the road.
However, I also find this quite horrendous 😅.
Note, returning null as an error causes the script to fail.