Clean Http Request Shutdown #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Request object now exists on the heap, allowing it to outlive whatever is making the request (e.g. the XHR object). We can now wait until all inflight IO events are completed before clearing the memory. This change fixes the crash observed in: #667
karlseguin
force-pushed
the
clean_xhr_shutdown
branch
from
82b2e8c to
e339ee3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation here is similar how the TCP server behaves: keeping track of which I/O events are in-flight and only shutting down when there are none.
This has been my white whale! 🤞