-
Notifications
You must be signed in to change notification settings - Fork 286
Input element properties #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
No tests (should have), but this case wrongly fails: .{ "document.createElement('input').type", "text" }Assuming it would also fail with the HTML Any other wrong defaults should at least be documented, but probably also fixed. |
src/browser/html/elements.zig
Outdated
| try testing.expectError(error.ExecutionError, runner.testCases(&.{.{ "elem_input.size = 0", null }}, .{})); | ||
| try testing.expectError(error.ExecutionError, runner.testCases(&.{.{ "elem_input.size = 'banana'", null }}, .{})); | ||
| try testProperty(&runner, "input", "src", "", "", &.{ | ||
| .{ .input = "foo", .is_str = true, .expected = "https://lightpanda.io/foo" }, // TODO stitch should work with spaces -> %20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mookums stitch should probably work with spaces -> %20 and such
0e0f577 to
0c0f7b4
Compare
0c0f7b4 to
19d4084
Compare
Depends on: lightpanda-io/libdom#28
https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement
Properties that are implemented by Netsurf, not deprecated, and not inherited from HTMLElement.
With these we probable have enough examples to make a generic implementation, for that note that there are some special cases:
i32, but set must be positiveu32Element.setAttributeandElement.getAttributePR created to make Playwright
page.getByRolework.