Fix HTMLImageElement #730
Merged
Fix HTMLImageElement #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTMLImageElement is the correct class name. However, it has a "legacy factory": Image (i.e. new Image()).
sjorsdonkers
approved these changes
May 30, 2025
Contributor
sjorsdonkers
left a comment
sjorsdonkers
left a comment
There was a problem hiding this comment.
Good to know, thanks!
See Alias consideration
| try parser.imageSetIsMap(self, is_map); | ||
| } | ||
|
|
||
| pub const Factory = struct { |
Contributor
There was a problem hiding this comment.
How about calling it Alias?
Suggested change
| pub const Factory = struct { | |
| pub const Alias = struct { |
Collaborator
Author
There was a problem hiding this comment.
Not quite an alias though, not per the spec and not how it's implemented. The most obvious practical difference is:
new Image() // valid;
new HTMLImageElement() // invalid...which I find ridiculous, but...But, also, HTMLImageElement != Image
Contributor
There was a problem hiding this comment.
I see, it's a strong typedef/alias, I also have seen it be called distinct variant, but I don't like that one.
Factory is somewhat implying it is creating an HTMLImageElement.
Up to you :) 🤷 I'd probably go with StrongAlias or Alias (and have the strong part be implicit). Probably StrongAlias as that would encode the knowledge of your reply.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTMLImageElement is the correct class name. However, it has a "legacy factory": Image (i.e. new Image()).