Fix url constructor #739
Merged
Fix url constructor #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
approved these changes
Jun 2, 2025
| opts: StitchOpts, | ||
| ) ![]const u8 { | ||
| if (base.len == 0) { | ||
| if (opts.alloc == .always) { |
Contributor
There was a problem hiding this comment.
fyi, in another PR and empty src is also added. Feel free to adopt in this PR
url, base were being joined in the wrong order. Switch to using URL.stitch if a base is given.
karlseguin
force-pushed
the
url_constructor
branch
from
1cfd23f to
ac75f9b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url, base were being joined in the wrong order. Switch to using URL.stitch if a base is given.