Fix crash when event target is the window. #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On page load, emitted by the page, the target is the window, but it's improperly cast since the pointer is actually `window.base`. This is going to be a problem in general for any Zig type dispatched as a target, but the Window one is the most obvious and the easiest to fix. If this issue comes up with other types, we'll need to come up with a more robust solution.
sjorsdonkers
reviewed
Jun 4, 2025
| // Ideally, we'd remove this duality. Failing that, we'll need to embed | ||
| // data into the *parser.EventTarget should we need this for other types. | ||
| // For now, for the Window, which is a singleton, we can do this: | ||
| if (@intFromPtr(et) == @intFromPtr(&page.window.base)) { |
Contributor
There was a problem hiding this comment.
Personally I would make every struct a extern struct and ban struct.
Would also help with slowly taking over libDOM functionality.
IMO zig got the default wrong in this case.
Collaborator
Author
There was a problem hiding this comment.
Hmmm...I was going to say "I don't want to make that decision".
Then I thought, "well, we could at least do it on Window for this specific problem...try it out".
But ya..no. There's a bunch of restrictions on what you can put into an extern struct. You can't, for example, have slices. So target: []const u8 = "", isn't valid.
If this is the way we go, it's a bigger change / discussion.
sjorsdonkers
approved these changes
Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On page load, emitted by the page, the target is the window, but it's improperly cast since the pointer is actually
window.base. This is going to be a problem in general for any Zig type dispatched as a target, but the Window one is the most obvious and the easiest to fix. If this issue comes up with other types, we'll need to come up with a more robust solution.