Fix activeElement #758
Closed
Fix activeElement #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#742 was only correct in isolation. The problem is that both html/document and dom/document are now attempting to attach state to the same *parser.Node. This is a problem because they're two different types of state. If an HTMLDocument is attached to the node, and you then try to access that as a DOMDocument, it'll crash. I moved the dom/document state (active_element) into the html/document. The other option is to introduce something like src/browser/state/document.zig and have both HTMLDocument and DOMDocument share/load that.
sjorsdonkers
reviewed
Jun 4, 2025
Co-authored-by: Sjors <[email protected]>
This reverts commit 22c6729.
Collaborator
Author
|
This issue impacts multiple cases. I'm going to try to "fix" them all. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#742 was only correct in isolation.
The problem is that both html/document and dom/document are now attempting to attach state to the same *parser.Node. This is a problem because they're two different types of state. If an HTMLDocument is attached to the node, and you then try to access that as a DOMDocument, it'll crash.
I moved the dom/document state (active_element) into the html/document.
The other option is to introduce something like src/browser/state/document.zig and have both HTMLDocument and DOMDocument share/load that.