Delay setting the requests' keepalive flag until the request is fully… #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… processed We currently set request._keepalive prematurely. There are [error cases] where the request could be abandoned before being fully drained. While we do try to drain in some cases, it isn't always possible. For this reason, request.keepalive is only set at the end of the request lifecycle, at which point we know the connection is ready to be re-used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… processed
We currently set request._keepalive prematurely. There are [error cases] where the request could be abandoned before being fully drained. While we do try to drain in some cases, it isn't always possible. For this reason, request.keepalive is only set at the end of the request lifecycle, at which point we know the connection is ready to be re-used.