Skip to content

Fix async https requests over a http forward proxy #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2025
Merged

Fix async https requests over a http forward proxy #875

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3049bb0
Fix async https requests over a http forward proxy
karlseguin Jul 10, 2025
4a12d04
Update src/http/client.zig
karlseguin Jul 10, 2025
795c925
Revert "Update src/http/client.zig"
karlseguin Jul 11, 2025
b387fd2
Update src/http/client.zig
karlseguin Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/http/client.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,10 @@ pub const Client = struct {
const proxy_type = self.proxy_type orelse return false;
return proxy_type == .forward;
}

fn isProxy(self: *const Client) bool {
return self.proxy_type != null;
}
};

const RequestOpts = struct {
Expand Down Expand Up @@ -792,8 +796,12 @@ pub const Request = struct {
.conn = .{ .handler = async_handler, .protocol = .{ .plain = {} } },
};

if (self._client.isConnectProxy() and self._proxy_secure) log.warn(.http, "ASYNC TLS CONNECT no impl.", .{});
if (self._request_secure) {
if (self._client.isConnectProxy() and self._proxy_secure) {
log.warn(.http, "not implemented", .{ .feature = "async tls connect" });
}

const is_proxy = self._client.isProxy();
if ((is_proxy and self._proxy_secure) or (!is_proxy and self._request_secure)) {
if (self._connection_from_keepalive) {
// If the connection came from the keepalive pool, than we already
// have a TLS Connection.
Expand Down