Fix parser identifier with escaped string #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
css-parser-error
branch
from
a885773 to
18796ae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the javascript
document.querySelectorAll('.\\:popover-open')failing with the error:ExpectedSelector.This selector searches for
class=":popover-open"and not for pseudo class:popover-openthanks to the escaped:.To fix the issue, I first allowed escaped char to be the first char of an identifier.
But due to #878, in fact the string currently sent to the parser is.:popover-openwhich is an invalid selector.So I added a temp hack to accept plain:as a first char of an identifier. This must be removed once #878 is fixed.#878 doesn't exist, i was fooled by string literal escapes 🤦♂️