Skip to content

Always make sure we have 1 free http state available for synchronous … #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Always make sure we have 1 free http state available for synchronous … #890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/http/client.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,12 @@ const AsyncQueue = struct {

fn _check(self: *AsyncQueue, repeat_delay: *?u63) !void {
const client = self.client;
if (client.freeSlotCount() == 1) {
// always leave 1 free connection for sync requests
repeat_delay.* = 10 * std.time.ns_per_ms;
return;
}

const state = client.state_pool.acquireOrNull() orelse {
// re-run this function in 10 milliseconds
repeat_delay.* = 10 * std.time.ns_per_ms;
Expand Down Expand Up @@ -3802,7 +3808,7 @@ const TestContext = struct {
errdefer loop.deinit();

var o = opts;
o.max_concurrent = 1;
o.max_concurrent = 2;

const client = try Client.init(testing.allocator, loop, o);
errdefer client.deinit();
Expand Down