Skip to content

dummy performance clearMarks and clearMeasures #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

dummy performance clearMarks and clearMeasures #895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions src/browser/dom/performance.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ pub const Interfaces = .{
PerformanceMark,
};

const MarkOptions = struct {
detail: ?Env.JsObject = null,
start_time: ?f64 = null,
};

// https://developer.mozilla.org/en-US/docs/Web/API/Performance
pub const Performance = struct {
pub const prototype = *EventTarget;
Expand Down Expand Up @@ -66,11 +61,21 @@ pub const Performance = struct {
return limitedResolutionMs(self.time_origin.read());
}

pub fn _mark(_: *Performance, name: []const u8, _options: ?MarkOptions, page: *Page) !PerformanceMark {
pub fn _mark(_: *Performance, name: []const u8, _options: ?PerformanceMark.Options, page: *Page) !PerformanceMark {
const mark: PerformanceMark = try .constructor(name, _options, page);
// TODO: Should store this in an entries list
return mark;
}

// TODO: fn _mark should record the marks in a lookup
pub fn _clearMarks(_: *Performance, name: ?[]const u8) void {
_ = name;
}

// TODO: fn _measures should record the marks in a lookup
pub fn _clearMeasures(_: *Performance, name: ?[]const u8) void {
_ = name;
}
};

// https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry
Expand Down Expand Up @@ -132,17 +137,23 @@ pub const PerformanceMark = struct {
proto: PerformanceEntry,
detail: ?Env.JsObject,

pub fn constructor(name: []const u8, _options: ?MarkOptions, page: *Page) !PerformanceMark {
const Options = struct {
detail: ?Env.JsObject = null,
start_time: ?f64 = null,
};

pub fn constructor(name: []const u8, _options: ?Options, page: *Page) !PerformanceMark {
const perf = &page.window.performance;

const options = _options orelse MarkOptions{};
const options = _options orelse Options{};
const start_time = options.start_time orelse perf._now();
const detail = if (options.detail) |d| try d.persist() else null;

if (start_time < 0.0) {
return error.TypeError;
}

const detail = if (options.detail) |d| try d.persist() else null;

const duped_name = try page.arena.dupe(u8, name);
const proto = PerformanceEntry{ .name = duped_name, .entry_type = .mark, .start_time = start_time };

Expand Down