Skip to content

Conversation

@karlseguin
Copy link
Collaborator

These are dummy implementations, but they do expose the ready and finished promise, and do resolve the finished promise, so it should unblock basic cases.

These are dummy implementations, but they do expose the ready and finished
promise, and do resolve the finished promise, so it should unblock basic cases.
@mookums
Copy link
Contributor

mookums commented Jul 15, 2025

looks fine to me. just curious what our general consensus is on the file-as-a-struct thing?

@karlseguin
Copy link
Collaborator Author

I personally find it troublesome. Always seems like sooner or later, you'll want to convert the type to a generic, or a union. But I keep trying to use it, because I find const SomeLongName = @import("some_long_name.zig").SomeLongName insulting to the aesthetics of the code.

My logic has been that, for these WebAPIs at least, they should be razor-focused. There's no reason that Animation or DataSet should be anything but a POJO..and the file-as-a-struct thing helps make the point.

You?

@karlseguin karlseguin merged commit 5229a7c into main Jul 15, 2025
10 checks passed
@karlseguin karlseguin deleted the animate branch July 15, 2025 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2025
@lightpanda-io lightpanda-io unlocked this conversation Jul 15, 2025
@lightpanda-io lightpanda-io locked and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants