Add element.remove() (needed by reddit) #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub fn _remove(self: *parser.Element) !void { | ||
| const as_node: *parser.Node = @ptrCast(self); | ||
| const parent = try parser.nodeParentNode(as_node) orelse return; | ||
| _ = try Node._removeChild(parent, as_node); |
Contributor
There was a problem hiding this comment.
hmm, I doubt this will update all location where a pointer to the deleted element was stored.
For example:
Code:
document.body.innerHTML = `
<div class="preference">
<label for="cheese">Do you like cheese?</label>
<input type="checkbox" name="cheese" id="cheese" />
</div>
`;
const label = document.querySelector('label[for="cheese"]');
label.control
const input = document.getElementById('cheese');
if (input) {
input.remove();
}
label.controlMaybe just leave a TODO
Contributor
There was a problem hiding this comment.
Alternatively elements could have a tombstone flag
Collaborator
Author
There was a problem hiding this comment.
Isn't this a widespread issue for any part of the code that removes/moves nodes?
Contributor
There was a problem hiding this comment.
It is, I personally prefer leaving breadcrumbs around to help our future debugging selves.
sjorsdonkers
approved these changes
Jul 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.