Skip to content

Fix: Properly handle node ownership when using appendChild and insertBefore #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
Merged

Fix: Properly handle node ownership when using appendChild and insertBefore #920

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4014e8
Fix: Properly handle node ownership when using appendChild and insert…
SrikanthKumarC Aug 3, 2025
c533b10
fix: traverse all children correctly
SrikanthKumarC Aug 4, 2025
f1e5134
refactor: use walker to traverse the nodes
SrikanthKumarC Aug 4, 2025
0a5f060
add tests and simplify walker traversal
SrikanthKumarC Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/browser/dom/node.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,19 @@ pub const Node = struct {
// Methods

pub fn _appendChild(self: *parser.Node, child: *parser.Node) !Union {
const self_owner = try parser.nodeOwnerDocument(self);
const child_owner = try parser.nodeOwnerDocument(child);

if (child_owner == null or (child_owner.? != self_owner.?)) {
const w = Walker{};
child.owner = self_owner;
var current = child;
while (try w.get_next(child, current)) |current_node| {
current_node.owner = self_owner;
current = current_node;
}
Copy link
Member

@krichprollsch krichprollsch Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about:

Suggested change
child.owner = self_owner;
var current = child;
while (try w.get_next(child, current)) |current_node| {
current_node.owner = self_owner;
current = current_node;
}
var current = child;
while (true) {
current.owner = self_owner;
current = try w.get_next(child, next) orelse break;
}

}

// TODO: DocumentFragment special case
const res = try parser.nodeAppendChild(self, child);
return try Node.toInterface(res);
Expand Down Expand Up @@ -290,6 +303,19 @@ pub const Node = struct {
}

pub fn _insertBefore(self: *parser.Node, new_node: *parser.Node, ref_node_: ?*parser.Node) !Union {
const self_owner = try parser.nodeOwnerDocument(self);
const new_node_owner = try parser.nodeOwnerDocument(new_node);

if (new_node_owner == null or (new_node_owner.? != self_owner.?)) {
const w = Walker{};
new_node.owner = self_owner;
var current = new_node;
while (try w.get_next(new_node, current)) |current_node| {
current_node.owner = self_owner;
current = current_node;
}
}

if (ref_node_) |ref_node| {
return Node.toInterface(try parser.nodeInsertBefore(self, new_node, ref_node));
}
Expand Down