Remove the http/Client.zig header_callback. #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback which was called on a per-header basis is removed. Only XHR was using this, and it was created before the HeaderIterator existed (because I didn't know we could iterate through the response headers in curl after the fact). The header_done_callback remains, but is now called header_callback (a bit confusing in the short term). The only difficulty was with fulfilled requests, which do not have an easy handle for our HeaderIterator. The existing code would segfault if transfer.responseHeaderIterator() was called on a fulfilled requests. The HeaderIterator is now a tagged union that abstracts whether the source of the response header is a curl easy, or just an injected list from the fulfilled requests.
krichprollsch
approved these changes
Aug 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback which was called on a per-header basis is removed. Only XHR was using this, and it was created before the HeaderIterator existed (because I didn't know we could iterate through the response headers in curl after the fact).
The header_done_callback remains, but is now called header_callback (a bit confusing in the short term).
The only difficulty was with fulfilled requests, which do not have an easy handle for our HeaderIterator. The existing code would segfault if transfer.responseHeaderIterator() was called on a fulfilled requests. The HeaderIterator is now a tagged union that abstracts whether the source of the response header is a curl easy, or just an injected list from the fulfilled requests.