Skip to content

Handle response without body #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

Handle response without body #973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b1acb
Handle response without body
sjorsdonkers Aug 25, 2025
e2d47e1
fix merge conflict
sjorsdonkers Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/browser/page.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,17 @@ pub const Page = struct {
self.clearTransferArena();

switch (self.mode) {
.pre => {
// Received a response without a body like: https://httpbin.io/status/200
// We assume we have received an OK status (checked in Client.headerCallback)
// so we load a blank document to navigate away from any prior page.
self.mode = .{ .parsed = {} };

const html_doc = try parser.documentHTMLParseFromStr("");
try self.setDocument(html_doc);

self.documentIsComplete();
},
.raw => |buf| {
self.mode = .{ .raw_done = buf.items };
self.documentIsComplete();
Expand Down Expand Up @@ -756,10 +767,6 @@ pub const Page = struct {
self.documentIsComplete();
}
},
.pre => {
// we didn't get any data.
self.documentIsComplete();
},
else => {
log.err(.app, "unreachable mode", .{ .mode = self.mode });
unreachable;
Expand Down