exit the browser on SIGINT signal #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Aug 28, 2025
src/main.zig
Outdated
| std.posix.sigaction(std.posix.SIG.INT, &std.posix.Sigaction{ | ||
| .handler = .{ | ||
| .handler = struct { | ||
| pub fn handler(_: c_int) callconv(.C) void { |
Collaborator
There was a problem hiding this comment.
.c for Zig 0.15 compatibility.
| .handler = .{ | ||
| .handler = struct { | ||
| pub fn handler(_: c_int) callconv(.C) void { | ||
| std.posix.exit(0); |
Collaborator
There was a problem hiding this comment.
If it's worth it, we can create a global ?App and ?Server, and try to shutdown them cleanly.
The one argument that I can make for going through the trouble is that, on deinit, the app flushes the telemetry queue. Can also do it in a separate PR.
Member
Author
There was a problem hiding this comment.
good point, it would be nice, I can try that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docker container, the browser doesn't exit on
CRTL-C(SIGINT).Catching the signal and exiting fixes the issue.
Reproduce the issue
You can reproduce the issue with the existing version of the docker image