Merge pull request #63 from lightpanda-io/v8_upgrade

V8 upgrade

Author: karlseguin

.dockerignore

@@ -1,6 +1,3 @@
-/zig-cache/
+/.zig-cache/
 /zig-out/
-/tools/ninja_gn_binaries*
-/v8-build/
-/gclient/
 /v8/

.gitignore

@@ -1,9 +1,3 @@
-/zig-cache/
-/tools/ninja_gn_binaries*
-/v8-build/
-/gclient/
-/v8/
-/zig-out/
-/vendor
-/libc_v8.a
 /.zig-cache/
+/zig-out/
+/v8/

.gn

@@ -13,11 +13,11 @@ RUN apt update && \
 ADD . /src/
 WORKDIR /src
 
-RUN zig build get-tools
+RUN zig build
 RUN zig build get-v8
-RUN zig build -Doptimize=ReleaseSafe
+RUN zig build -Doptimize=ReleaseSafe build-v8
 
-RUN mv /src/v8-build/$ARCH-$OS/release/ninja/obj/zig/libc_v8.a /src/libc_v8.a
+RUN mv v8/out/release/obj/zig/libc_v8.a /src/libc_v8.a
 
 FROM scratch as artifact
 

BUILD.gn

@@ -4,87 +4,24 @@ Builds V8 from official source and provides C bindings and a Zig API. This would
 
 V8 is the JS/WASM runtime that powers Google Chrome and Microsoft Edge.
 
-## Project Status
-Static libs are built and released with [Github Actions](https://github.com/fubark/zig-v8/actions).
-| Native | Cross Compile | Target | Demo Binary ([shell.zig](https://github.com/fubark/zig-v8/blob/master/src/shell.zig))* |
-| ------ | ------ | -------- | -------- |
-| ✅ | | Linux x64 | shell - 19 M |
-| ✅ | ✅ | Windows x64 | shell.exe - 14 M |
-| ✅ | | macOS x64 | shell - 24 M |
-| ✅ | ✅ | macOS arm64 | shell - 21 M |
-
-\* shell.zig is a JS repl and statically linked with v8. Compiled with -Drelease-safe. The V8 dependency can be further reduced in size if you don't need all the features (eg. disable WASM runtime).
-
-| Toolchain | Fresh Build* | Cached Build* |
-| ------ | ------ | ------ |
-| gclient, full feature + v8 toolchain | 1.5-2 hrs | with sccache: 10-20min |
-| minimal feature + v8 toolchain | 40-50 min | with sccache: 5-10min |
-| minimal feature + zig c++ toolchain |  | with zig caching:  |
-
-\* Time is measured on standard Github instances.
-
 ## System Requirements
 - Zig compiler (0.14.0). Clone and build https://github.com/ziglang/zig.
 - Python 3 (2.7 seems to work as well)
+- unzip (`apt install unzip`)
 - For native macOS builds:
   - XCode (You won't need this when using zig's c++ toolchain!)<br/>
 if you come across this error:<br />
 `xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance`<br />
   run `sudo xcode-select -s /Applications/Xcode.app/Contents/Developer`
 
 ## Build
-By default UseGclient=false in build.zig. This will pull the minimum sources and deps needed to build v8 and reduce build times.
-
-If you want to include everything, set UseGclient=true. Build times can be quite long using gclient but afterwards rerunning "zig build" should be incremental. You can also use sccache for better incremental build times.
+Compiling v8 will take 20+ minutes.
 
 ```sh
-# Clone the repo.
-git clone https://github.com/fubark/zig-v8.git
-cd zig-v8
-
-# Pull prebuilt GN/Ninja. If UseGclient=true, it also pulls depot_tools.
-zig build get-tools
-
-# Pull v8 source
 zig build get-v8
-
-# Build, resulting static library should be at:
-# v8-build/{target}/{debug/release}/ninja/obj/zig/libc_v8.a
-# On windows, use msvc: zig build zig build -Doptimize=ReleaseSafe -Dtarget=x86_64-windows-msvc
-zig build -Doptimize=ReleaseSafe
-```
-## Demo
-```sh
-# shell.zig is a simple JS repl.
-# Assumes you've already built v8.
-zig build run -Dpath="src/shell.zig" -Doptimize=ReleaseSafe
-
-# If you built v8 using the zig toolchain, you'll need to add the flag here as well.
-zig build run -Dpath="src/shell.zig" -Doptimize=ReleaseSafe -Dzig-toolchain
-```
-
-## Cross Compiling
-With Zig's toolchain, we can build V8 from libstdc++ that's bundled with zig and cross compile to foreign targets/cpus! Simply amazing. Eventually, this will also replace the default V8 toolchain for native builds after further testing.
-### Linux x64 (Host) to MacOS arm64 (Target)
-```sh
-# Assumes you've fetched tools and v8 sources. See above build steps.
-# Resulting static lib will be at:
-# v8-build/aarch64-macos/release/ninja/obj/zig/libc_v8.a
-zig build -Doptimize=ReleaseSafe -Dtarget=aarch64-macos-gnu -Dzig-toolchain
-```
-
-### Cross compile to Windows with gnu (mingw64)
-Zig comes with mingw64 source and headers so you'll be able to target Windows without MSVC.
-```sh
-zig build -Doptimize=ReleaseSafe -Dtarget=x86_64-windows-gnu -Dzig-toolchain
+zig build build-v8
 ```
 
-## Usage
-
-See src/shell.zig or test/test.zig on how to use the library with the Zig API as well as build.zig (fn linkV8) on how to link with the built V8 static library.
-
-## Contributing
-
-The C bindings is incomplete but it should be relatively easy to add more as we need them.
+Once complete, you can find v8 in: `v8/out/debug/obj/zig/libc_v8.a`
 
-C API naming convention should closely follow the V8 C++ API.
+If you build with `zig build -Doptimize=ReleaseFast build-v8`, v8 will be in `v8/out/release/obj/zig/libc_v8.a`.

Dockerfile

@@ -0,0 +1,99 @@
+# This file is used by the GN meta build system to find the root of the source
+# tree and to set startup options. For documentation on the values set in this
+# file, run "gn help dotfile" at the command line.
+
+# Use the default python3 so gn succeeds. Not sure why deno requires python2 atm.
+script_executable = "python3"
+
+# The location of the build configuration file.
+buildconfig = "//build/config/BUILDCONFIG.gn"
+
+# These are the targets to check headers for by default. The files in targets
+# matching these patterns (see "gn help label_pattern" for format) will have
+# their includes checked for proper dependencies when you run either
+# "gn check" or "gn gen --check".
+check_targets = []
+
+# The secondary source root is a parallel directory tree where
+# GN build files are placed when they can not be placed directly
+# in the source tree, e.g. for third party source trees.
+secondary_source = "//v8/"
+
+default_args = {
+  clang_use_chrome_plugins = false
+  is_component_build = false
+  linux_use_bundled_binutils = false
+  use_dummy_lastchange = true
+  use_sysroot = false
+  simple_template_names = false
+
+  # Minimize size of debuginfo in distributed static library.
+  line_tables_only = true
+  no_inline_line_tables = true
+  symbol_level = 1
+  use_debug_fission = false
+
+  v8_embedder_string = "-lightpanda"
+
+  v8_enable_sandbox = false
+  v8_enable_javascript_promise_hooks = true
+  v8_promise_internal_field_count = 1
+  v8_use_external_startup_data = false
+
+  v8_enable_pointer_compression = true
+
+  v8_imminent_deprecation_warnings = false
+
+  # This flag speeds up the performance of fork/execve on Linux systems for
+  # embedders which use it (like Node.js). It works by marking the pages that
+  # V8 allocates as MADV_DONTFORK. Without MADV_DONTFORK, the Linux kernel
+  # spends a long time manipulating page mappings on fork and exec which the
+  # child process doesn't generally need to access.
+  v8_enable_private_mapping_fork_optimization = true
+
+  # We prefer embedders to bring their own compression
+  v8_use_zlib = true
+  v8_enable_snapshot_compression = false
+
+  # Disable handle zapping for performance
+  v8_enable_handle_zapping = false
+  # Ensure allocation of typed arrays and arraybuffers always goes through
+  # the embedder's ArrayBufferAllocator, otherwise small buffers get moved
+  # around by the garbage collector but embedders normally want them to have
+  # fixed addresses.
+  v8_typed_array_max_size_in_heap = 0
+
+  # Historically these always had 2 slots. Keep for compat.
+  v8_array_buffer_internal_field_count = 2
+  v8_array_buffer_view_internal_field_count = 2
+
+  # Enabling the shared read-only heap comes with a restriction that all
+  # isolates running at the same time must be created from the same snapshot.
+  # This is problematic for Deno, which has separate "runtime" and "typescript
+  # compiler" snapshots, and sometimes uses them both at the same time.
+  v8_enable_shared_ro_heap = false
+
+  # V8 11.6 hardcoded an assumption in `mksnapshot` that shared RO heap
+  # is enabled. In our case it's disabled so without this flag we can't
+  # compile.
+  v8_enable_verify_heap = false
+
+  # Enable V8 object print for debugging.
+  # v8_enable_object_print = true
+
+  # V8 12.3 added google/fuzztest as a third party dependency.
+  # https://chromium.googlesource.com/v8/v8.git/+/d5acece0c9b89b18716c177d1fcc8f734191e1e2%5E%21/#F4
+  #
+  # This flag disables it.
+  v8_enable_fuzztest = false
+
+  # Disable v8::HandleScope LIFO checks.
+  # https://chromium-review.googlesource.com/c/v8/v8/+/5110566
+  #
+  # rusty_v8 scopes are not on the stack.
+  v8_enable_v8_checks = false
+
+  use_relative_vtables_abi = false
+
+  icu_use_data_file = false
+}

README.md

@@ -1,10 +1,10 @@
 # Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
 # Based on https://github.com/denoland/rusty_v8/blob/main/BUILD.gn
-import("//build/config/host_byteorder.gni")
 
 static_library("c_v8") {
   complete_static_lib = true
-  sources = [ "../../binding.cpp" ]
+
+  sources = [ "../binding.cpp" ]
   deps = [
     "//build/config:shared_library_deps",
     "//:v8",
@@ -43,8 +43,4 @@ config("c_v8_config") {
       "-fansi-escape-codes",
     ]
   }
-
-  if (is_debug && is_clang && !is_win) {
-    cflags += [ "-glldb" ]
-  }
 }