Skip to content

Commit 935fd66

Browse files
committed
Add Float16Array which is supported in this version of v8
1 parent eb08184 commit 935fd66

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

src/binding.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,14 +206,14 @@ const v8::Int32Array* v8__Int32Array__New(
206206
);
207207
}
208208

209-
// const v8::Float16Array* v8__Float16Array__New(
210-
// const v8::ArrayBuffer& buf,
211-
// size_t byte_offset,
212-
// size_t length) {
213-
// return local_to_ptr(
214-
// v8::Float16Array::New(ptr_to_local(&buf), byte_offset, length)
215-
// );
216-
// }
209+
const v8::Float16Array* v8__Float16Array__New(
210+
const v8::ArrayBuffer& buf,
211+
size_t byte_offset,
212+
size_t length) {
213+
return local_to_ptr(
214+
v8::Float16Array::New(ptr_to_local(&buf), byte_offset, length)
215+
);
216+
}
217217

218218
const v8::Float32Array* v8__Float32Array__New(
219219
const v8::ArrayBuffer& buf,

src/binding.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ typedef Value Uint32Array;
3636
typedef Value Int32Array;
3737
typedef Value BigUint64Array;
3838
typedef Value BigInt64Array;
39-
// typedef Value Float16Array;
39+
typedef Value Float16Array;
4040
typedef Value Float32Array;
4141
typedef Value Float64Array;
4242
typedef Value ArrayBufferView;
@@ -166,10 +166,10 @@ const Int32Array* v8__Int32Array__New(
166166
size_t byte_offset,
167167
size_t length);
168168

169-
// const Float16Array* v8__Float16Array__New(
170-
// const ArrayBuffer* buf,
171-
// size_t byte_offset,
172-
// size_t length);
169+
const Float16Array* v8__Float16Array__New(
170+
const ArrayBuffer* buf,
171+
size_t byte_offset,
172+
size_t length);
173173

174174
const Float32Array* v8__Float32Array__New(
175175
const ArrayBuffer* buf,

0 commit comments

Comments
 (0)