Merge pull request #93 from lightpanda-io/v8_upgrade

Upgrade to 14.0.365.4 (latest stable)

Author: karlseguin

build-tools/.gn

@@ -96,4 +96,10 @@ default_args = {
   use_relative_vtables_abi = false
 
   icu_use_data_file = false
+
+  # requires rust toolchain
+  v8_enable_temporal_support = false
+
+  # build fails on some linux systems without this
+  use_llvm_libatomic = false
 }

build-tools/deps_get.py

@@ -0,0 +1,16 @@
+#!/usr/bin/env python
+
+import sys
+import json
+
+def main():
+    with open(sys.argv[1], 'r') as f:
+        lookup = json.load(f)
+    entry = lookup[sys.argv[2]];
+    if isinstance(entry, str):
+        print(entry)
+    else:
+        print(entry["url"])
+
+if __name__ == "__main__":
+    main()

build-tools/deps_parse.py

@@ -0,0 +1,23 @@
+#!/usr/bin/env python
+
+import sys
+import json
+
+def Var(arg):
+    if arg == 'chromium_url':
+        return 'https://chromium.googlesource.com'
+    return '@' + arg
+
+def Str(arg):
+    return '@' + arg
+
+def main():
+    with open(sys.argv[1], 'r') as f:
+        content = f.read()
+
+    out = {}
+    exec(content, globals(), out)
+    print(json.dumps(out['deps']))
+
+if __name__ == "__main__":
+    main()

build-tools/get_v8.sh

@@ -5,9 +5,10 @@ set -o errtrace # inherits trap on ERR in function and subshell
 
 source utils.sh
 
-REVISION=13.6.233.8
+REVISION=14.0.365.4
 
-cloneDep() {
+
+clone() {
   if [ -d "${2}" ]; then
     warn "dependency ${2} already exists, skipping"
   else
@@ -21,30 +22,38 @@ cloneDep() {
   fi
 }
 
+cloneDep() {
+  dep_info=$(python3 deps_get.py deps.json "${1}")
+  IFS=@ read -r dep_path dep_commit <<< "${dep_info}"
+  clone $dep_path $2 $dep_commit
+}
+
 if [ -d "src" ]; then
   warn "v8/src/ already exists, only cloning dependencies"
 else
   say "cloning V8 into v8/src/"
   git clone --depth=1 --branch ${REVISION} "https://chromium.googlesource.com/v8/v8.git" src
 fi
 
-# TODO: we should generate this from src/DEPS
-cloneDep 'https://chromium.googlesource.com/chromium/src/build.git' 'src/build' '451ef881d77fff0b7a8bbfa61934f5e4a35b4c96'
-cloneDep 'https://chromium.googlesource.com/chromium/src/third_party/jinja2.git' 'src/third_party/jinja2' '5e1ee241ab04b38889f8d517f2da8b3df7cfbd9a'
-cloneDep 'https://chromium.googlesource.com/chromium/src/buildtools.git' 'src/buildtools' '6f359296daa889aa726f3d05046b9f37be241169'
-cloneDep 'https://chromium.googlesource.com/chromium/src/tools/clang.git' 'src/tools/clang' '0078c27c43cae91e96bb28d8a4407045966e0542'
-cloneDep 'https://chromium.googlesource.com/chromium/src/third_party/zlib.git' 'src/third_party/zlib' '788cb3c270e8700b425c7bdca1f9ce6b0c1400a9'
-cloneDep 'https://chromium.googlesource.com/external/github.com/google/googletest.git' 'src/third_party/googletest/src' '52204f78f94d7512df1f0f3bea1d47437a2c3a58'
-cloneDep 'https://chromium.googlesource.com/chromium/src/third_party/markupsafe.git' 'src/third_party/markupsafe' '9f8efc8637f847ab1ba984212598e6fb9cf1b3d4'
-cloneDep 'https://chromium.googlesource.com/chromium/deps/icu.git' 'src/third_party/icu' 'c9fb4b3a6fb54aa8c20a03bbcaa0a4a985ffd34b'
-cloneDep 'https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git' 'src/third_party/abseil-cpp' '3fbb10e80d80e3430224b75add53c47c7a711612'
-cloneDep 'https://chromium.googlesource.com/chromium/src/third_party/simdutf.git' 'src/third_party/simdutf' '40d1fa26cd5ca221605c974e22c001ca2fb12fde'
-cloneDep 'https://chromium.googlesource.com/external/github.com/google/highway.git' 'src/third_party/highway/src/' '00fe003dac355b979f36157f9407c7c46448958e'
-cloneDep 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git' 'src/third_party/libc++/src' '449310fe2e37834a7e62972d2a690cade2ef596b'
-cloneDep 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git' 'src/third_party/libc++abi/src' '94c5d7a8edc09f0680aee57548c0b5d400c2840d'
-cloneDep 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git' 'src/third_party/llvm-libc/src' '188329a7f2118a957efbb3e6219c255e7dba997c'
-cloneDep 'https://chromium.googlesource.com/external/github.com/Maratyszcza/FP16.git' 'src/third_party/fp16/src' '0a92994d729ff76a58f692d3028ca1b64b145d91'
-cloneDep 'https://chromium.googlesource.com/external/github.com/fastfloat/fast_float.git' 'src/third_party/fast_float/src' 'cb1d42aaa1e14b09e1452cfdef373d051b8c02a4'
+python3 deps_parse.py src/DEPS > deps.json
+
+cloneDep 'build' 'src/build'
+cloneDep 'third_party/jinja2' 'src/third_party/jinja2'
+cloneDep 'buildtools' 'src/buildtools'
+cloneDep 'tools/clang' 'src/tools/clang'
+cloneDep 'third_party/zlib' 'src/third_party/zlib'
+cloneDep 'third_party/googletest/src' 'src/third_party/googletest/src'
+cloneDep 'third_party/markupsafe' 'src/third_party/markupsafe'
+cloneDep 'third_party/icu' 'src/third_party/icu'
+cloneDep 'third_party/abseil-cpp' 'src/third_party/abseil-cpp'
+cloneDep 'third_party/simdutf' 'src/third_party/simdutf'
+cloneDep 'third_party/highway/src' 'src/third_party/highway/src/'
+cloneDep 'third_party/libc++/src' 'src/third_party/libc++/src'
+cloneDep 'third_party/libc++abi/src' 'src/third_party/libc++abi/src'
+cloneDep 'third_party/llvm-libc/src' 'src/third_party/llvm-libc/src'
+cloneDep 'third_party/fp16/src' 'src/third_party/fp16/src'
+cloneDep 'third_party/fast_float/src' 'src/third_party/fast_float/src'
+cloneDep 'third_party/dragonbox/src' 'src/third_party/dragonbox/src'
 
 # Add an empty gclient_args.gni so gn is happy. gclient also creates an empty file.
 echo "# generated by get_v8.sh" >  src/build/config/gclient_args.gni

src/binding.cpp

@@ -1229,15 +1229,15 @@ const v8::Array* v8__Object__GetPropertyNames(
 
 const v8::Value* v8__Object__GetPrototype(
        const v8::Object& self) {
-  return local_to_ptr(ptr_to_local(&self)->GetPrototype());
+  return local_to_ptr(ptr_to_local(&self)->GetPrototypeV2());
 }
 
 void v8__Object__SetPrototype(
         const v8::Object& self,
         const v8::Context& ctx,
         const v8::Object& prototype,
         v8::Maybe<bool>* out) {
-  *out = ptr_to_local(&self)->SetPrototype(ptr_to_local(&ctx), ptr_to_local(&prototype));
+  *out = ptr_to_local(&self)->SetPrototypeV2(ptr_to_local(&ctx), ptr_to_local(&prototype));
 }
 
 void v8__Object__SetAlignedPointerInInternalField(

src/binding.h

@@ -278,6 +278,7 @@ typedef struct ResourceConstraints {
     usize max_young_generation_size_;
     usize initial_old_generation_size_;
     usize initial_young_generation_size_;
+    uint64_t physical_memory_size_;
     uint32_t* stack_limit_;
 } ResourceConstraints;
 
@@ -297,7 +298,7 @@ typedef struct CreateParams {
     int embedder_wrapper_object_index;
     void* fatal_error_callback;
     void* oom_error_callback;
-    void* heap;
+    void* cpp_heap;
 } CreateParams;
 usize v8__Isolate__CreateParams__SIZEOF();
 void v8__Isolate__CreateParams__CONSTRUCT(CreateParams* buf);