Skip to content

Conversation

@lijamie98
Copy link
Contributor

We should either fix the version to the latest release or create the master-SNAPSHOT:uber.

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.06%. Comparing base (5cbfe0c) to head (8012a91).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #682   +/-   ##
=========================================
  Coverage     80.06%   80.06%           
  Complexity     1210     1210           
=========================================
  Files           212      212           
  Lines          4790     4790           
  Branches        406      406           
=========================================
  Hits           3835     3835           
  Misses          703      703           
  Partials        252      252           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@overcat
Copy link
Member

overcat commented Mar 17, 2025

Hi @lijamie98, when the user first retrieves this library from JitPack, JitPack will automatically create a release, which takes some time. I noticed that the master uber has been created correctly. https://jitpack.io/com/github/lightsail-network/java-stellar-sdk/master-SNAPSHOT/

@overcat
Copy link
Member

overcat commented Mar 17, 2025

But I think we can make some improvements by building immediately after each commit, instead of waiting for the user to try to fetch it: https://docs.jitpack.io/building/#building-ahead-of-time

@lijamie98
Copy link
Contributor Author

lijamie98 commented Mar 18, 2025

For the example classes, can we consider use the most recent stable release instead of the edge (master-SNAPPSHOT)?

@overcat overcat merged commit 979fb81 into lightsail-network:master Mar 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants