Skip to content

Conversation

@lijamie98
Copy link
Contributor

No description provided.

@lijamie98 lijamie98 force-pushed the add-get-sac-balance branch from 30cd755 to 0a8849e Compare May 22, 2025 22:38
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.23%. Comparing base (a1edad0) to head (af2ad03).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/stellar/sdk/SorobanServer.java 87.87% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #691      +/-   ##
============================================
+ Coverage     80.18%   80.23%   +0.05%     
- Complexity     1227     1228       +1     
============================================
  Files           213      213              
  Lines          4820     4853      +33     
  Branches        412      413       +1     
============================================
+ Hits           3865     3894      +29     
- Misses          703      705       +2     
- Partials        252      254       +2     
Files with missing lines Coverage Δ
src/main/java/org/stellar/sdk/SorobanServer.java 84.92% <87.87%> (+0.58%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@overcat overcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It looks great. I have left some minor suggestions for changes.

import java.util.List;
import java.util.Optional;
import java.util.UUID;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using wildcard imports. I know both have their advantages, but this has been discussed in other PRs before. Since we have a standard now, let's adhere to it.
https://github.com/lightsail-network/java-stellar-sdk/blob/master/CONTRIBUTING.md#code-style

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually from the auto formatter, which is google-java-formatter. What do you think we let the formatter handle this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think google-java-formatter does this; are you using IDEA? IDEA does this by default.
https://www.baeldung.com/intellij-disable-wildcard-import

@overcat overcat enabled auto-merge (squash) May 24, 2025 08:24
@overcat overcat merged commit 68121f7 into lightsail-network:master May 24, 2025
9 checks passed
@overcat
Copy link
Member

overcat commented May 24, 2025

🎉 Merged! Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants