feat!: introduce SignerKey class for enhanced signer key handling.
#712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
============================================
+ Coverage 80.41% 80.74% +0.32%
- Complexity 1269 1294 +25
============================================
Files 215 214 -1
Lines 5030 5052 +22
Branches 421 425 +4
============================================
+ Hits 4045 4079 +34
+ Misses 724 715 -9
+ Partials 261 258 -3
🚀 New features to boost your workflow:
|
overcat
force-pushed
the
refactor/signer-key-and-signer
branch
from
06d89fc to
587f67b
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a comprehensive refactoring that replaces the legacy Signer and SignedPayloadSigner classes with a new unified SignerKey class for enhanced signer key handling in the Stellar SDK. The changes aim to provide a more robust and type-safe API for working with different types of signer keys.
Key changes include:
- Introduction of a new
SignerKeyclass that supports all four Stellar signer types (Ed25519, Pre-auth TX, Hash-X, and Ed25519 Signed Payload) - Removal of deprecated
SignerandSignedPayloadSignerclasses - Updates to operation classes and transaction preconditions to use the new
SignerKeytype - Enhanced StrKey functionality for signed payload validation
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/stellar/sdk/SignerKey.java | New comprehensive SignerKey class supporting all signer types with XDR conversion capabilities |
| src/main/java/org/stellar/sdk/StrKey.java | Updated to work with raw byte arrays and added signed payload validation |
| src/main/java/org/stellar/sdk/operations/SetOptionsOperation.java | Updated to use new SignerKey class instead of XDR SignerKey |
| src/main/java/org/stellar/sdk/operations/RevokeSignerSponsorshipOperation.java | Updated to use new SignerKey class instead of XDR SignerKey |
| src/main/java/org/stellar/sdk/TransactionPreconditions.java | Updated to use List instead of List<org.stellar.sdk.xdr.SignerKey> |
| src/main/java/org/stellar/sdk/KeyPair.java | Removed deprecated XDR SignerKey methods |
| src/main/java/org/stellar/sdk/Signer.java | Deleted - functionality moved to SignerKey |
| src/main/java/org/stellar/sdk/SignedPayloadSigner.java | Deleted - functionality moved to SignerKey.Ed25519SignedPayload |
| CHANGELOG.md | Documents breaking changes and new features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.