refactor: add balance id validation.

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Update:
 - feat: add `isValidSignedPayload` to `StrKey` class, this function can be used to validate the ed25519 signed payload. ([#712](https://github.com/stellar/java-stellar-sdk/pull/712))
 - feat: add `signExtraSignersPayload` to sign extra signers payloads in `Transaction` class. ([#713](https://github.com/stellar/java-stellar-sdk/pull/713))
+- refactor: add balance id validation. ([#722](https://github.com/stellar/java-stellar-sdk/pull/722))
 
 ### Breaking changes:
 - feat: add `org.stellar.sdk.SignerKey` for enhanced signer key handling. ([#712](https://github.com/stellar/java-stellar-sdk/pull/712))

src/main/java/org/stellar/sdk/operations/ClaimClaimableBalanceOperation.java

@@ -66,7 +66,6 @@ public abstract static class ClaimClaimableBalanceOperationBuilder<
           B extends ClaimClaimableBalanceOperationBuilder<C, B>>
       extends OperationBuilder<C, B> {
     public B balanceId(@NonNull String balanceId) {
-      // TODO: add validation in other places
       if (balanceId.length() != 8 + 64) {
         throw new IllegalArgumentException("invalid balanceId: " + balanceId);
       }

src/main/java/org/stellar/sdk/operations/ClawbackClaimableBalanceOperation.java

@@ -68,6 +68,9 @@ public abstract static class ClawbackClaimableBalanceOperationBuilder<
           B extends ClawbackClaimableBalanceOperationBuilder<C, B>>
       extends OperationBuilder<C, B> {
     public B balanceId(@NonNull String balanceId) {
+      if (balanceId.length() != 8 + 64) {
+        throw new IllegalArgumentException("invalid balanceId: " + balanceId);
+      }
       this.balanceId = balanceId.toLowerCase();
       return self();
     }

src/main/java/org/stellar/sdk/operations/RevokeClaimableBalanceSponsorshipOperation.java

@@ -86,6 +86,9 @@ public abstract static class RevokeClaimableBalanceSponsorshipOperationBuilder<
           B extends RevokeClaimableBalanceSponsorshipOperationBuilder<C, B>>
       extends OperationBuilder<C, B> {
     public B balanceId(@NonNull String balanceId) {
+      if (balanceId.length() != 8 + 64) {
+        throw new IllegalArgumentException("invalid balanceId: " + balanceId);
+      }
       this.balanceId = balanceId.toLowerCase();
       return self();
     }