Skip to content

fix: fix handling of transaction metadata versioning in AssembledTransaction class. #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
overcat merged 1 commit into from
Jul 23, 2025
Merged

fix: fix handling of transaction metadata versioning in AssembledTransaction class. #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- feat: add `isValidSignedPayload` to `StrKey` class, this function can be used to validate the ed25519 signed payload. ([#712](https://github.com/stellar/java-stellar-sdk/pull/712))
- feat: add `signExtraSignersPayload` to sign extra signers payloads in `Transaction` class. ([#713](https://github.com/stellar/java-stellar-sdk/pull/713))
- refactor: add balance id validation. ([#722](https://github.com/stellar/java-stellar-sdk/pull/722))
- fix: fix handling of transaction metadata versioning in `AssembledTransaction` class. ([#723](https://github.com/stellar/java-stellar-sdk/pull/723))

### Breaking changes:
- feat: add `org.stellar.sdk.SignerKey` for enhanced signer key handling. ([#712](https://github.com/stellar/java-stellar-sdk/pull/712))
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/org/stellar/sdk/contract/AssembledTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,12 @@ public T submit() {
throw new IllegalArgumentException(
"Unable to convert transaction meta to TransactionMeta", e);
}
SCVal resultVal = transactionMeta.getV3().getSorobanMeta().getReturnValue();
SCVal resultVal;
if (transactionMeta.getV3() != null) {
resultVal = transactionMeta.getV3().getSorobanMeta().getReturnValue();
} else {
resultVal = transactionMeta.getV4().getSorobanMeta().getReturnValue();
}
return parseResultXdrFn != null ? parseResultXdrFn.apply(resultVal) : (T) resultVal;
}

Expand Down