Skip to content

LCORE-1319: PR title checker configuration #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 2 commits into from
Mar 30, 2026
+32 −0
Merged

LCORE-1319: PR title checker configuration #1429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feae91c
PR title checker config
tisnik Mar 30, 2026
d0c8c97
PR title checker GH action
tisnik Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/pr-title-checker-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"LABEL": {
"name": "title needs formatting",
"color": "EEEEEE"
},
"CHECKS": {
"prefixes": ["LCORE-"]
},
"MESSAGES": {
"success": "All OK",
"failure": "Failing CI test",
"notice": ""
}
}
18 changes: 18 additions & 0 deletions .github/workflows/pr-title-checker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: "PR Title Checker"
on:
pull_request_target:
types:
- opened
- edited
- synchronize
- labeled
- unlabeled
jobs:
check:
runs-on: ubuntu-latest
steps:
- uses: thehanimo/pr-title-checker@v1.4.3
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
pass_on_octokit_error: false
configuration_path: .github/pr-title-checker-config.json
Comment on lines +3 to +18
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

wf=".github/workflows/pr-title-checker.yaml"

echo "Checking trigger type:"
rg -n 'pull_request_target' "$wf"

echo
echo "Checking action reference pinning style:"
rg -n 'uses:\s*thehanimo/pr-title-checker@' "$wf"

echo
echo "Checking explicit permissions blocks:"
rg -n '^\s*permissions:' "$wf" -C2 || true

Repository: lightspeed-core/lightspeed-stack

Length of output: 255

Consider pinning the action to a commit SHA for supply-chain hardening.

While pull_request_target with secrets access is your stated preference, the tag-pinned action reference (thehanimo/pr-title-checker@v1.4.3, line 14) creates a supply-chain risk—tags can be retargeted at the source. Pinning to a specific commit SHA mitigates this without requiring changes to your trigger model.

Explicit permissions declaration (contents, pull-requests, issues) is optional given your acceptance of the implicit full-context model.

SHA pinning example 
-      - uses: thehanimo/pr-title-checker@v1.4.3
+      - uses: thehanimo/pr-title-checker@<commit_sha>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/pr-title-checker.yaml around lines 3 - 18, Replace the
tag-pinned action reference thehanimo/pr-title-checker@v1.4.3 with a commit SHA
to harden the supply chain (update the step that uses the action in the job
"check"); keep the same inputs (GITHUB_TOKEN, pass_on_octokit_error,
configuration_path) but change the uses line to
thehanimo/pr-title-checker@<commit-sha> where <commit-sha> is the exact full
commit hash from the action repo you want to lock to, and ensure you verify the
chosen commit before committing the change.

Loading