Make Board references constant where possible to improve clarity and avoid unnecessary copies#1166
Merged
lightvector merged 1 commit intolightvector:masterfrom Mar 10, 2026
Conversation
…d avoid unnecessary copies
Owner
|
Thanks for the change! I had to check things over to verify that the board (and the hist) actually is const in places, but I think this looks good. |
Contributor
Author
|
Thanks for the merging! Actually, I've discovered much more unnecessary copies (using CLang-Tidy). The things should be treated carefully, because in some places copy syntax is used intentionally and it's incorrectly to use const references. But they should be emphasized explicitly. Also, I've found a lot of places where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
NNEvaluator::evaluateis a hot path and it would be nice to get rid of redundant copies. And it looks consistent becauseBoardHistoryis also passed by const reference toevaluate.