corpus: remove submodule #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
force-pushed
the
ligurio/gh-xxxx-detach-corpus-submodule
branch
3 times, most recently
from
a84cc1e to
26f1473
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-detach-corpus-submodule
branch
2 times, most recently
from
cbb12bb to
3c65c94
Compare
A Git submodule was introduced in commit 341ac1e ("corpus: initial integration"). The main idea was to keep in sync source code of tests and their seed corpus. However, this approach is not convenient: seed corpus updates often and someone need to regularly bump submodule version, otherwise outdated seed corpus is used.
ligurio
force-pushed
the
ligurio/gh-xxxx-detach-corpus-submodule
branch
from
3c65c94 to
33352d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Git submodule was introduced in commit 341ac1e ("corpus: initial integration"). The main idea was to keep in sync source code of tests and their seed corpus.
However, this approach is not convenient: