-
Notifications
You must be signed in to change notification settings - Fork 3
tests/lapi: add string tests #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6cc9b5e
to
db026a5
Compare
13733c9
to
3832770
Compare
25d0560
to
2460426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Sergey!
Thanks for the patch!
LGTM, with a bunch of the nits below.
Also, I'm a little bit concerned about using MAX_INT
for string's max_len
(especially for tests with string.rep
). Maybe it is better to decrease this value?
11fddde
to
0201990
Compare
9188875
to
a237a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Sergey!
Thanks for the fixes!
LGTM!
a237a20
to
bcb43e6
Compare
The patch adds a fuzzing tests for Lua string functions and two helpers: `random_locale()`.
bcb43e6
to
d5c4f6f
Compare
The commit "tests/lapi: add string tests" [1]. 1. ligurio/lua-c-api-tests@0508724 Follows up ligurio/lua-c-api-tests#124 Related to tarantool/tarantool#11401 Related to tarantool/tarantool#11301
The commit "tests/lapi: add string tests" [1]. 1. ligurio/lua-c-api-tests@0508724 Follows up ligurio/lua-c-api-tests#124 Related to tarantool/tarantool#11401 Related to tarantool/tarantool#11301
The function `string.pack()` raises, the patch wraps it by `xpcall()` and suppress errors with message "invalid format option". Follows up #124
The function `string.pack()` raises, the patch wraps it by `xpcall()` and suppress errors with message "invalid format option". Follows up #124
The function `string.pack()` raises, the patch wraps it by `xpcall()` and suppress errors with message "invalid format option". Follows up #124
The patch fixes the following issues: - `string.byte()` returns the internal numeric codes of the characters, not a single number. - `string.char()` returns `nil` when values `i` or `j` are outside the acceptable range (less than zero and greater than the length of the string). It is not documented. Follows up #124
The patch fixes description (synopsis is at the end of the description) and fixes lower boundary for `n`, with `n` equal to zero assertion calculates negative number in right part of expression. Follows up #124
The patch fixes the following issues: - `string.byte()` returns the internal numeric codes of the characters, not a single number. - `string.char()` returns `nil` when values `i` or `j` are outside the acceptable range (less than zero and greater than the length of the string). It is not documented. Follows up #124
The patch fixes description (synopsis is at the end of the description) and fixes lower boundary for `n`, with `n` equal to zero assertion calculates negative number in right part of expression. Follows up #124
The patch fixes the following issues: - `string.byte()` returns the internal numeric codes of the characters, not a single number. - `string.char()` returns `nil` when values `i` or `j` are outside the acceptable range (less than zero and greater than the length of the string). It is not documented. Follows up #124
The patch fixes description (synopsis is at the end of the description) and fixes lower boundary for `n`, with `n` equal to zero assertion calculates negative number in right part of expression. Follows up #124
The commit "tests/lapi: add string tests" [1]. 1. ligurio/lua-c-api-tests@0508724 Follows up ligurio/lua-c-api-tests#124 Follows up ligurio/lua-c-api-tests#148 Related to tarantool/tarantool#11401 Related to tarantool/tarantool#11301
The commit "tests/lapi: add string tests" [1]. 1. ligurio/lua-c-api-tests@0508724 Follows up ligurio/lua-c-api-tests#124 Follows up ligurio/lua-c-api-tests#148 Related to tarantool/tarantool#11401 Related to tarantool/tarantool#11301
Depends on
consume_integers()
andconsume_numbers()
luzer#44