Skip to content

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented Mar 26, 2025

@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-string branch 12 times, most recently from 6cc9b5e to db026a5 Compare March 27, 2025 07:09
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-string branch 3 times, most recently from 13733c9 to 3832770 Compare April 15, 2025 10:48
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-string branch 3 times, most recently from 25d0560 to 2460426 Compare May 14, 2025 11:12
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the patch!
LGTM, with a bunch of the nits below.
Also, I'm a little bit concerned about using MAX_INT for string's max_len (especially for tests with string.rep). Maybe it is better to decrease this value?

@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-string branch 2 times, most recently from 11fddde to 0201990 Compare May 27, 2025 08:40
@ligurio ligurio requested a review from Buristan May 27, 2025 08:41
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-string branch 2 times, most recently from 9188875 to a237a20 Compare May 30, 2025 14:05
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the fixes!
LGTM!

@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-string branch from a237a20 to bcb43e6 Compare June 2, 2025 08:03
The patch adds a fuzzing tests for Lua string functions and
two helpers: `random_locale()`.
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-string branch from bcb43e6 to d5c4f6f Compare June 2, 2025 08:17
@ligurio ligurio merged commit 0508724 into master Jun 2, 2025
12 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-lapi-string branch June 2, 2025 08:54
ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Jun 3, 2025
ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Jun 3, 2025
ligurio added a commit that referenced this pull request Jul 28, 2025
The function `string.pack()` raises, the patch wraps it by `xpcall()`
and suppress errors with message "invalid format option".

Follows up #124
ligurio added a commit that referenced this pull request Jul 28, 2025
The function `string.pack()` raises, the patch wraps it by `xpcall()`
and suppress errors with message "invalid format option".

Follows up #124
ligurio added a commit that referenced this pull request Jul 28, 2025
The function `string.pack()` raises, the patch wraps it by `xpcall()`
and suppress errors with message "invalid format option".

Follows up #124
ligurio added a commit that referenced this pull request Aug 28, 2025
The patch fixes the following issues:

- `string.byte()` returns the internal numeric codes of the
  characters, not a single number.
- `string.char()` returns `nil` when values `i` or `j` are
   outside the acceptable range (less than zero and greater than
   the length of the string). It is not documented.

Follows up #124
ligurio added a commit that referenced this pull request Aug 28, 2025
The patch fixes description (synopsis is at the end of the
description) and fixes lower boundary for `n`, with `n` equal
to zero assertion calculates negative number in right part of
expression.

Follows up #124
ligurio added a commit that referenced this pull request Aug 29, 2025
The patch fixes the following issues:

- `string.byte()` returns the internal numeric codes of the
  characters, not a single number.
- `string.char()` returns `nil` when values `i` or `j` are
   outside the acceptable range (less than zero and greater than
   the length of the string). It is not documented.

Follows up #124
ligurio added a commit that referenced this pull request Aug 29, 2025
The patch fixes description (synopsis is at the end of the
description) and fixes lower boundary for `n`, with `n` equal
to zero assertion calculates negative number in right part of
expression.

Follows up #124
ligurio added a commit that referenced this pull request Aug 29, 2025
The patch fixes the following issues:

- `string.byte()` returns the internal numeric codes of the
  characters, not a single number.
- `string.char()` returns `nil` when values `i` or `j` are
   outside the acceptable range (less than zero and greater than
   the length of the string). It is not documented.

Follows up #124
ligurio added a commit that referenced this pull request Aug 29, 2025
The patch fixes description (synopsis is at the end of the
description) and fixes lower boundary for `n`, with `n` equal
to zero assertion calculates negative number in right part of
expression.

Follows up #124
ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Sep 11, 2025
ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants