tests/lapi: os tests #141
Merged
tests/lapi: os tests #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-os
branch
from
205ba33 to
ba5c59f
Compare
Buristan
approved these changes
Jul 17, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the patch!
LGTM, with a minor comments below.
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Jul 18, 2025
Follows up ligurio/lua-c-api-tests#141 Related to tarantool/tarantool#11401 Related to tarantool/tarantool#11301
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Jul 18, 2025
Follows up ligurio/lua-c-api-tests#141 Related to tarantool/tarantool#11470
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-os
branch
3 times, most recently
from
345a3fc to
33e1d6e
Compare
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Jul 18, 2025
Follows up ligurio/lua-c-api-tests#141 Related to tarantool/tarantool#11470
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-os
branch
2 times, most recently
from
6f144fd to
2984514
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-os
branch
from
2984514 to
d8ba3bd
Compare
Buristan
approved these changes
Jul 24, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the fixes!
LGTM!
The patch adds tests for the functions in os library except the following functions: `os.tmpname`, `os.rename`, `os.remove`, `os.execute`, `os.clock`.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-os
branch
from
d8ba3bd to
2a06358
Compare
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Jul 28, 2025
Follows up ligurio/lua-c-api-tests#141 Related to tarantool/tarantool#11470
ligurio
added a commit
that referenced
this pull request
Jul 28, 2025
In some cases `os.time()` returns `nil` and this breaks the test. The patch fixes that. Follows up #141
ligurio
added a commit
that referenced
this pull request
Jul 28, 2025
The `mktime()` function (which is used inside `os.time()`)
returns -1 for cases when the time since the Epoch cannot be
represented. In this case, `os.time()` returns `nil`:
```
luajit -e "print(os.time({year = 1970, month = 1, day = 1, sec = -9 * 60 * 60 - 1}))"
nil
```
The patch fixes an assertion in the test and allows `nil` as
a result of the function.
Follows up #141
ligurio
added a commit
that referenced
this pull request
Jul 28, 2025
The `mktime()` function (which is used inside `os.time()`)
returns -1 for cases when the time since the Epoch cannot be
represented. In this case, `os.time()` returns `nil`:
```
luajit -e "print(os.time({year = 1970, month = 1, day = 1, sec = -9 * 60 * 60 - 1}))"
nil
```
The patch fixes an assertion in the test and allows `nil` as
a result of the function.
Follows up #141
ligurio
added a commit
that referenced
this pull request
Aug 28, 2025
The patch updates assertions for values returned by `os.date()` and `os.time()`. Follows up #141
ligurio
added a commit
that referenced
this pull request
Aug 29, 2025
The patch updates assertions for values returned by `os.date()` and `os.time()`. Follows up #141
ligurio
added a commit
that referenced
this pull request
Aug 29, 2025
The patch updates assertions for values returned by `os.date()` and `os.time()`. Follows up #141
ligurio
added a commit
that referenced
this pull request
Aug 29, 2025
The patch updates assertions for values returned by `os.date()` and `os.time()`. Follows up #141
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Sep 11, 2025
Follows up ligurio/lua-c-api-tests#141 Related to tarantool/tarantool#11470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.