tests/lapi: add debug tests #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-debug
branch
from
d90d076 to
33941a1
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-debug
branch
from
33941a1 to
fb812c7
Compare
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-debug
branch
from
fb812c7 to
775479f
Compare
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Jul 24, 2025
Follows up ligurio/lua-c-api-tests#144 Related to tarantool/tarantool#11470
Buristan
requested changes
Jul 25, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the patch!
Please consider my comments below.
Maybe it is worth joining the tests into a single one, since the hook functionality and TestOneInput wrapper are the same for all tests.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-debug
branch
3 times, most recently
from
65d2ef2 to
08949ae
Compare
Buristan
approved these changes
Jul 25, 2025
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
Sergey,
Thanks for the fixes!
LGTM!
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Jul 28, 2025
Follows up ligurio/lua-c-api-tests#144 Related to tarantool/tarantool#11470
The commit adds tests for the following functions in debug library: `debug.getlocal()`, `debug.getupvalue()` and `debug.getinfo()`.
ligurio
force-pushed
the
ligurio/gh-xxxx-lapi-debug
branch
from
08949ae to
492a73e
Compare
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Jul 28, 2025
Follows up ligurio/lua-c-api-tests#144 Related to tarantool/tarantool#11470
ligurio
added a commit
that referenced
this pull request
Jul 28, 2025
Since commit 8e35f0c ("cmake: bump luzer version") `fdp:oneof()` in luzer API returns two values: a table's item and it's index. This breaks test `debug_torture_test.lua` with a message below > bad argument #2 to 'insert' (number expected, got string) because `fdp:one()` passed to `table.insert()` makes a call with three arguments: table, hook mask ("string") and index ("number"), while `table.insert()` with three arguments expects table, `pos` ("number"), and a value (any type). Follows up #144
ligurio
added a commit
that referenced
this pull request
Jul 28, 2025
Since commit 8e35f0c ("cmake: bump luzer version") `fdp:oneof()` in luzer API returns two values: a table's item and it's index. This breaks test `debug_torture_test.lua` with a message below > bad argument #2 to 'insert' (number expected, got string) because `fdp:one()` passed to `table.insert()` makes a call with three arguments: table, hook mask ("string") and index ("number"), while `table.insert()` with three arguments expects table, `pos` ("number"), and a value (any type). Follows up #144
ligurio
added a commit
that referenced
this pull request
Jul 28, 2025
Since commit 8e35f0c ("cmake: bump luzer version") `fdp:oneof()` in luzer API returns two values: a table's item and it's index. This breaks test `debug_torture_test.lua` with a message below > bad argument #2 to 'insert' (number expected, got string) because `fdp:one()` passed to `table.insert()` makes a call with three arguments: table, hook mask ("string") and index ("number"), while `table.insert()` with three arguments expects table, `pos` ("number"), and a value (any type). Follows up #144
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Sep 11, 2025
ligurio
added a commit
to ligurio/lua-c-api-corpus
that referenced
this pull request
Sep 11, 2025
Follows up ligurio/lua-c-api-tests/pull/144 Related to tarantool/tarantool/issues/11401 Related to tarantool/tarantool/pull/11301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.