Fix lapi tests #150
Merged
Fix lapi tests #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buristan
requested changes
Jul 28, 2025
There was a problem hiding this comment.
Hi, Sergey!
Thanks for the patch-set.
I'll continue with the review per-patch below.
[PATCH 1/4] tests/lapi: fix os_time_test
Thanks for the patch!
Please consider my comment below.
It would be nice to add the more verbose description in the commit message as well.
Buristan
requested changes
Jul 28, 2025
Buristan
approved these changes
Jul 28, 2025
Buristan
approved these changes
Jul 28, 2025
The `mktime()` function (which is used inside `os.time()`)
returns -1 for cases when the time since the Epoch cannot be
represented. In this case, `os.time()` returns `nil`:
```
luajit -e "print(os.time({year = 1970, month = 1, day = 1, sec = -9 * 60 * 60 - 1}))"
nil
```
The patch fixes an assertion in the test and allows `nil` as
a result of the function.
Follows up #141
The function `string.pack()` raises, the patch wraps it by `xpcall()` and suppress errors with message "invalid format option". Follows up #124
The function `utf8.offset()` raises, the patch wraps it by `xpcall()` and suppress errors with message "initial position is a continuation byte". Follows up #143
Since commit 8e35f0c ("cmake: bump luzer version") `fdp:oneof()` in luzer API returns two values: a table's item and it's index. This breaks test `debug_torture_test.lua` with a message below > bad argument #2 to 'insert' (number expected, got string) because `fdp:one()` passed to `table.insert()` makes a call with three arguments: table, hook mask ("string") and index ("number"), while `table.insert()` with three arguments expects table, `pos` ("number"), and a value (any type). Follows up #144
ligurio
force-pushed
the
ligurio/gh-xxxx-fix-lapi-tests
branch
from
eca75a5 to
87efa8e
Compare
Buristan
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.