tests/capi: speedup luaL_loadbuffer_proto_test #152
Merged
+0
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch removes debug hook and testing using bytecode in luaL_loadbuffer_proto_test. Debug hook was added in the commit c772887 ("tests: enable debug hook in luaL_loadbuffer_proto"), the hook slows down execution, breaks JIT compilation in LuaJIT and there were no bugs found with it. Testing with bytecode has been added the commit 0b8c9b8 ("tests: execute bytecode in luaL_loadbuffer_proto_test"), it slows down running each chunk in two times and there were no bugs found by added function.
Buristan
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch removes debug hook and testing using bytecode in luaL_loadbuffer_proto_test. Debug hook was added in the commit c772887 ("tests: enable debug hook in luaL_loadbuffer_proto"), the hook slows down execution, breaks JIT compilation in LuaJIT and there were no bugs found with it. Testing with bytecode has been added the commit 0b8c9b8 ("tests: execute bytecode in luaL_loadbuffer_proto_test"), it slows down running each chunk in two times and there were no bugs found by added function.