Skip to content

Conversation

@haeber
Copy link
Contributor

@haeber haeber commented Oct 22, 2025

See #647 .

@haeber haeber marked this pull request as ready for review October 22, 2025 10:40
@haeber haeber changed the title add PHPUnit 12 compatibility; typos; PHP 8.4 compatibility; some cleanup add PHPUnit 12 compatibility; typos; PHP 8.4 compatibility; some cleanup; drop PHP 7.4 Oct 22, 2025
@haeber haeber force-pushed the master branch 6 times, most recently from f1e48d7 to b7baa1c Compare October 22, 2025 15:44
@alexislefebvre
Copy link
Collaborator

Thanks for your work.

Could you please split this PR and open a second PR with only Markdown and code comment changes?


- name: Require Annotations v1/v2 to require for PHP 8+
if: startsWith(matrix.php-version, '7.') != true
run: composer require --no-update "doctrine/annotations:^1.8.0|^2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test (later) if this is still necessary.

@alexislefebvre alexislefebvre merged commit a36b57e into liip:master Oct 22, 2025
17 checks passed
@alexislefebvre
Copy link
Collaborator

alexislefebvre commented Oct 22, 2025

Thanks!

I merged it as is. If you contribute again, please split the changes, ideally in several PRs, or at least in several commits, to ease reviewing.

Here is the release with these changes: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/4.14.0

@haeber
Copy link
Contributor Author

haeber commented Oct 22, 2025

Thanks!

I merged it as is. If you contribute again, please split the changes, ideally in several PRs, or at least in several commits, to ease reviewing.

Here is the release with these changes: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/4.14.0

Thanks a lot, actually I read your message and wanted to split the PR into 2 PRs, but my time was up and I had to commute home (and therefore wanted to do it tomorrow). But thanks for the hint, I will split the next change directly from the start, if it has multiple changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants