Conversation
bellisk
force-pushed
the
feat/adapt-schema.org-rdf-profile-for-multilingual-metadata
branch
from
032cbdc to
c599fbe
Compare
bellisk
force-pushed
the
feat/adapt-schema.org-rdf-profile-for-multilingual-metadata
branch
from
c599fbe to
95cd666
Compare
bellisk
commented
Mar 31, 2026
Contributor
Author
bellisk
left a comment
bellisk
left a comment
There was a problem hiding this comment.
Thank you for adding the tests, I really appreciate that! However, I think it would make more sense to test that the multilingual metadata fields are correctly mapped when calling the public method graph_from_dataset, rather than the private methods _basic_fields_graph and _distribution_basic_fields_graph. What if we turned out to be overwriting the output of one of those private methods when creating the graph, for example?
Wdyt?
stefina
force-pushed
the
feat/adapt-schema.org-rdf-profile-for-multilingual-metadata
branch
from
cc9f069 to
d13b792
Compare
stefina
force-pushed
the
feat/adapt-schema.org-rdf-profile-for-multilingual-metadata
branch
from
d13b792 to
8bb676e
Compare
Member
|
@bellisk yeah, that makes a lot of sense! I changed the tests accordingly, please check again :) |
stefina
approved these changes
Apr 1, 2026
stefina
deleted the
feat/adapt-schema.org-rdf-profile-for-multilingual-metadata
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.