Fix use of private wrap-fx in macro#160
Merged
lilactown merged 2 commits intolilactown:masterfrom Jan 5, 2026
Merged
Conversation
This ends up expanding in the caller's namespace, which references the private `wrap-fx` and leads to a compiler warning under Figwheel. I believe Shadow is suppressing these so it wasn't caught.
SevereOverfl0w
force-pushed
the
wrap-fx
branch
from
72b88ea to
1112baa
Compare
lilactown
reviewed
Jan 5, 2026
Owner
lilactown
left a comment
lilactown
left a comment
There was a problem hiding this comment.
I see, bummer about the difference between shadow and other compilers. Change makes sense!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ends up expanding in the caller's namespace, which references the private
wrap-fxand leads to a compiler warning under Figwheel. I believe Shadow is suppressing these so it wasn't caught.