Merged
Conversation
Member
|
Hi, thank you for the addition. This is just (almost) equivalent to linspace(start, end, num: num, include-end: include-end).map(x => calc.pow(base, x))I think. I believe this would be a cleaner implementation and also properly work with inverted ranges where end < start. Also, can you add a few simple tests to |
Contributor
Author
|
agreed. updated 👍 |
Member
|
Please review your previous change. You changed the impl of linspace now instead of logspace. |
Member
|
Looks good now, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to display numbers on a logspace diagram without having to rewrite the same lines everytime, so here it is.
https://numpy.org/doc/stable/reference/generated/numpy.logspace.html