Open
Conversation
|
Reviewing the composer.json file, the ^8.3 constraint for PHP will prevent this package from being installed on systems running PHP 8.0, 8.1, and 8.2. For broader compatibility within the PHP 8 ecosystem, I recommend changing this to ^8.0. |
Contributor
Author
|
Yes, that was essentially a typo. I meant to put in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this is for some reason common within the Magento space - but due to semantic versioning it is completely unnecessary to disallow future feature versions of PHP.
Note: the single pipe
|notation is deprecated.