Skip to content

handle approve/reject states and rejection comments #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tgallant wants to merge 10 commits into
base: aem650
Choose a base branch
from
Open

handle approve/reject states and rejection comments #2

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
98c40d7
adds more log messages
tgallant May 10, 2022
bd60d2c
adds addLabel request
tgallant May 12, 2022
ed71a37
update translation object state
tgallant May 12, 2022
6294ca2
account for approved/rejected states when determining next state
tgallant May 12, 2022
638918f
add translation object comment
tgallant May 12, 2022
b80b5b1
linting
tgallant May 12, 2022
68cedec
update translation object state fixes
tgallant May 12, 2022
aafb252
in progress wip
tgallant May 12, 2022
871de3e
wip
tgallant May 12, 2022
2ad9504
version 2.2
tgallant May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions ...be/granite/translation/connector/bootstrap/core/impl/BootstrapTranslationServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,11 +538,21 @@ public CommentCollection<Comment> getTranslationObjectCommentCollection(String s

@Override
public void addTranslationObjectComment(String strTranslationJobID, TranslationObject translationObject,
Comment comment) throws TranslationException {
log.trace("BootstrapTranslationServiceImpl.addTranslationObjectComment");

throw new TranslationException("This function is not implemented",
TranslationException.ErrorCode.SERVICE_NOT_IMPLEMENTED);
Comment comment) throws TranslationException {
Copy link

@hanibhat hanibhat May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the margin change intentional?

log.trace("BootstrapTranslationServiceImpl.addTranslationObjectComment");
String annotation = comment.getAnnotationData();
String author = comment.getAuthorName();
String fileName = String.format("%s_%s.txt");
Copy link

@hanibhat hanibhat May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specifiers are missing. Did you mean to pass annotation and author?

String objectPath = String.format("%s.%s", getObjectPath(translationObject), exportFormat);
String message = comment.getMessage();
String body = String.format("%s\n\n%s", objectPath, message);
InputStream inputStream = new ByteArrayInputStream(body.getBytes());
String labels = String.format("%s,comment", strTranslationJobID);
try {
liltApiClient.uploadFile(fileName, labels, inputStream);
} catch (Exception e) {
log.warn("error during addTranslationObjectComment {}", e);
}
}

@Override
Expand Down