Implemented dsp cmajor code for maracas#80
Conversation
|
I love the effect playing around with the panning, I hadn't thought to try anything like that. Maybe the clap sound can be improved with something similar! For the Maracas themselves, could you experiment with it a little bit more? I used a single "hit" of a Maracas from this video as reference when listening to your drum sound and to me it sounds like:
|
|
Ohh I see. Yea I'll try to get it sound much as closer to the video. |
- reduce to a shorter burst time - Slightly rasied the pitch
|
Hi @lilyvanoekel, I have done some improvements on the sound, let me know your feedback |
|
thanks @RakinduM ! I'll have a look over the weekend! |
dsp/drums/Maracas.cmajor
Outdated
There was a problem hiding this comment.
We should avoid hardcoding a sample rate, we can use float(processor.frequency). But also, I'm curious what this is for? Silent samples are already handled by the loop above:
while (triggerVelocity == 0)
advance();
There was a problem hiding this comment.
Sorry I read this wrong initially, we do need it, but we should replace 44100.0f with float(processor.frequency)
There was a problem hiding this comment.
Ohh yes i'll replace it, my bad
There was a problem hiding this comment.
I have refactored it to float(processor.frequency). Let me know if there are any thing to be changed
|
Thank you for all of your contributions @RakinduM , you even inspired another PR by someone else 😄 |
🎵 Summary of Changes
Implemented dsp cmajor code for maracas and added the maracas sound for testing
🏷️ Type of Change
💡 Motivation/Reason
As a developer with a passion for music, I find this project is really interesting. Instead of Tweaking knobs, hitting keys n pads and messing with Ableton, this time I wanted to create a realistic maracas sound in the code. Not an expert of sound designing, but I gave it a shot.
🧪 Testing Done
npm run build)Cmajor: Run patchcommand🔗 Related Issues
Fixes #43
📝 Additional Notes
Created sample - maracas-sample.mp3
Please Ignore background noises, I was outside when recording it :)
📋 Checklist