refactor(BaseDriver): make drivers implement the driver.Driver interface

Signed-off-by: Ansuman Sahoo <[email protected]>

Author: unsuman

pkg/qemu/qemu_driver.go

@@ -47,7 +47,7 @@ type LimaQemuDriver struct {
 	vhostCmds []*exec.Cmd
 }
 
-func New(inst *store.Instance) *LimaQemuDriver {
+func New(inst *store.Instance, sshLocalPort int) *LimaQemuDriver {
 	// virtserialport doesn't seem to work reliably: https://github.com/lima-vm/lima/issues/2064
 	// but on Windows default Unix socket forwarding is not available
 	var virtioPort string
@@ -56,9 +56,10 @@ func New(inst *store.Instance) *LimaQemuDriver {
 		virtioPort = ""
 	}
 	return &LimaQemuDriver{
-		Instance:   inst,
-		VSockPort:  0,
-		VirtioPort: virtioPort,
+		Instance:     inst,
+		VSockPort:    0,
+		VirtioPort:   virtioPort,
+		SSHLocalPort: sshLocalPort,
 	}
 }
 
@@ -503,3 +504,32 @@ func (a *qArgTemplateApplier) applyTemplate(qArg string) (string, error) {
 	}
 	return b.String(), nil
 }
+
+func (l *LimaQemuDriver) Name() string {
+	return "qemu"
+}
+
+func (l *LimaQemuDriver) Initialize(_ context.Context) error {
+	return nil
+}
+
+func (l *LimaQemuDriver) CanRunGUI() bool {
+	return false
+}
+
+func (l *LimaQemuDriver) RunGUI() error {
+	return nil
+}
+
+func (l *LimaQemuDriver) Register(_ context.Context) error {
+	return nil
+}
+
+func (l *LimaQemuDriver) Unregister(_ context.Context) error {
+	return nil
+}
+
+func (l *LimaQemuDriver) ForwardGuestAgent() bool {
+	// if driver is not providing, use host agent
+	return l.VSockPort == 0 && l.VirtioPort == ""
+}

pkg/vz/vz_driver_darwin.go

@@ -77,11 +77,12 @@ type LimaVzDriver struct {
 	machine *virtualMachineWrapper
 }
 
-func New(inst *store.Instance) *LimaVzDriver {
+func New(inst *store.Instance, sshLocalPort int) *LimaVzDriver {
 	return &LimaVzDriver{
-		Instance:   inst,
-		VSockPort:  2222,
-		VirtioPort: "",
+		Instance:     inst,
+		VSockPort:    2222,
+		VirtioPort:   "",
+		SSHLocalPort: sshLocalPort,
 	}
 }
 
@@ -249,3 +250,44 @@ func (l *LimaVzDriver) GuestAgentConn(_ context.Context) (net.Conn, error) {
 	}
 	return nil, errors.New("unable to connect to guest agent via vsock port 2222")
 }
+
+func (l *LimaVzDriver) Name() string {
+	return "vz"
+}
+
+func (l *LimaVzDriver) Register(_ context.Context) error {
+	return nil
+}
+
+func (l *LimaVzDriver) Unregister(_ context.Context) error {
+	return nil
+}
+
+func (l *LimaVzDriver) ChangeDisplayPassword(_ context.Context, _ string) error {
+	return nil
+}
+
+func (l *LimaVzDriver) GetDisplayConnection(_ context.Context) (string, error) {
+	return "", nil
+}
+
+func (l *LimaVzDriver) CreateSnapshot(_ context.Context, _ string) error {
+	return errors.New("unimplemented")
+}
+
+func (l *LimaVzDriver) ApplySnapshot(_ context.Context, _ string) error {
+	return errors.New("unimplemented")
+}
+
+func (l *LimaVzDriver) DeleteSnapshot(_ context.Context, _ string) error {
+	return errors.New("unimplemented")
+}
+
+func (l *LimaVzDriver) ListSnapshots(_ context.Context) (string, error) {
+	return "", errors.New("unimplemented")
+}
+
+func (l *LimaVzDriver) ForwardGuestAgent() bool {
+	// If driver is not providing, use host agent
+	return l.VSockPort == 0 && l.VirtioPort == ""
+}

pkg/wsl2/wsl_driver_windows.go

@@ -53,16 +53,17 @@ type LimaWslDriver struct {
 	VirtioPort   string
 }
 
-func New(inst *store.Instance) *LimaWslDriver {
+func New(inst *store.Instance, sshLocalPort int) *LimaWslDriver {
 	port, err := freeport.VSock()
 	if err != nil {
 		logrus.WithError(err).Error("failed to get free VSock port")
 	}
 
 	return &LimaWslDriver{
-		Instance:   inst,
-		VSockPort:  port,
-		VirtioPort: "",
+		Instance:     inst,
+		VSockPort:    port,
+		VirtioPort:   "",
+		SSHLocalPort: sshLocalPort,
 	}
 }
 
@@ -206,3 +207,48 @@ func (l *LimaWslDriver) GuestAgentConn(ctx context.Context) (net.Conn, error) {
 	}
 	return winio.Dial(ctx, sockAddr)
 }
+
+func (l *LimaWslDriver) Name() string {
+	return "wsl2"
+}
+
+func (l *LimaWslDriver) Initialize(_ context.Context) error {
+	return nil
+}
+
+func (l *LimaWslDriver) CreateDisk(_ context.Context) error {
+	return nil
+}
+
+func (l *LimaWslDriver) Register(_ context.Context) error {
+	return nil
+}
+
+func (l *LimaWslDriver) ChangeDisplayPassword(_ context.Context, _ string) error {
+	return nil
+}
+
+func (l *LimaWslDriver) GetDisplayConnection(_ context.Context) (string, error) {
+	return "", nil
+}
+
+func (l *LimaWslDriver) CreateSnapshot(_ context.Context, _ string) error {
+	return fmt.Errorf("unimplemented")
+}
+
+func (l *LimaWslDriver) ApplySnapshot(_ context.Context, _ string) error {
+	return fmt.Errorf("unimplemented")
+}
+
+func (l *LimaWslDriver) DeleteSnapshot(_ context.Context, _ string) error {
+	return fmt.Errorf("unimplemented")
+}
+
+func (l *LimaWslDriver) ListSnapshots(_ context.Context) (string, error) {
+	return "", fmt.Errorf("unimplemented")
+}
+
+func (l *LimaWslDriver) ForwardGuestAgent() bool {
+	// If driver is not providing, use host agent
+	return l.VSockPort == 0 && l.VirtioPort == ""
+}