Skip to content

Commit bff7bdc

Browse files
committed
refactor(BaseDriver): remove driver.BaseDriver from driver(wsl2) level
Signed-off-by: Ansuman Sahoo <[email protected]>
1 parent a1f79d5 commit bff7bdc

File tree

3 files changed

+20
-59
lines changed

3 files changed

+20
-59
lines changed

pkg/wsl2/fs.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@ import (
1111

1212
"github.com/sirupsen/logrus"
1313

14-
"github.com/lima-vm/lima/pkg/driver"
1514
"github.com/lima-vm/lima/pkg/fileutils"
15+
"github.com/lima-vm/lima/pkg/store"
1616
"github.com/lima-vm/lima/pkg/store/filenames"
1717
)
1818

1919
// EnsureFs downloads the root fs.
20-
func EnsureFs(ctx context.Context, driver *driver.BaseDriver) error {
21-
baseDisk := filepath.Join(driver.Instance.Dir, filenames.BaseDisk)
20+
func EnsureFs(ctx context.Context, inst *store.Instance) error {
21+
baseDisk := filepath.Join(inst.Dir, filenames.BaseDisk)
2222
if _, err := os.Stat(baseDisk); errors.Is(err, os.ErrNotExist) {
2323
var ensuredBaseDisk bool
24-
errs := make([]error, len(driver.Instance.Config.Images))
25-
for i, f := range driver.Instance.Config.Images {
26-
if _, err := fileutils.DownloadFile(ctx, baseDisk, f.File, true, "the image", *driver.Instance.Config.Arch); err != nil {
24+
errs := make([]error, len(inst.Config.Images))
25+
for i, f := range inst.Config.Images {
26+
if _, err := fileutils.DownloadFile(ctx, baseDisk, f.File, true, "the image", *inst.Config.Arch); err != nil {
2727
errs[i] = err
2828
continue
2929
}

pkg/wsl2/wsl_driver_others.go

Lines changed: 0 additions & 43 deletions
This file was deleted.

pkg/wsl2/wsl_driver_windows.go

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"github.com/Microsoft/go-winio/pkg/guid"
1414
"github.com/sirupsen/logrus"
1515

16-
"github.com/lima-vm/lima/pkg/driver"
1716
"github.com/lima-vm/lima/pkg/freeport"
1817
"github.com/lima-vm/lima/pkg/limayaml"
1918
"github.com/lima-vm/lima/pkg/reflectutil"
@@ -47,18 +46,23 @@ var knownYamlProperties = []string{
4746
const Enabled = true
4847

4948
type LimaWslDriver struct {
50-
*driver.BaseDriver
49+
Instance *store.Instance
50+
51+
SSHLocalPort int
52+
VSockPort int
53+
VirtioPort string
5154
}
5255

53-
func New(driver *driver.BaseDriver) *LimaWslDriver {
56+
func New(inst *store.Instance) *LimaWslDriver {
5457
port, err := freeport.VSock()
5558
if err != nil {
5659
logrus.WithError(err).Error("failed to get free VSock port")
5760
}
58-
driver.VSockPort = port
59-
driver.VirtioPort = ""
61+
6062
return &LimaWslDriver{
61-
BaseDriver: driver,
63+
Instance: inst,
64+
VSockPort: port,
65+
VirtioPort: "",
6266
}
6367
}
6468

@@ -123,10 +127,10 @@ func (l *LimaWslDriver) Start(ctx context.Context) (chan error, error) {
123127
distroName := "lima-" + l.Instance.Name
124128

125129
if status == store.StatusUninitialized {
126-
if err := EnsureFs(ctx, l.BaseDriver); err != nil {
130+
if err := EnsureFs(ctx, l.Instance); err != nil {
127131
return nil, err
128132
}
129-
if err := initVM(ctx, l.BaseDriver.Instance.Dir, distroName); err != nil {
133+
if err := initVM(ctx, l.Instance.Dir, distroName); err != nil {
130134
return nil, err
131135
}
132136
}
@@ -139,8 +143,8 @@ func (l *LimaWslDriver) Start(ctx context.Context) (chan error, error) {
139143

140144
if err := provisionVM(
141145
ctx,
142-
l.BaseDriver.Instance.Dir,
143-
l.BaseDriver.Instance.Name,
146+
l.Instance.Dir,
147+
l.Instance.Name,
144148
distroName,
145149
errCh,
146150
); err != nil {

0 commit comments

Comments
 (0)