build(deps): bump github.com/mikefarah/yq/v4 from 4.45.2 to 4.45.4 #3530
Conversation
dependabot
bot
added
dependencies
| module github.com/lima-vm/lima | ||
|
|
||
| go 1.23.0 | ||
| go 1.24 |
There was a problem hiding this comment.
Not sure if that is acceptable for us. It looks like a gratuitous bump; should I ask upstream why they changed it?
There was a problem hiding this comment.
Let's keep 1.23 unless this update is urgent
There was a problem hiding this comment.
We should revert #3494 then and stay with yq 4.45.1. The 4.45.3 and 4.45.4 releases are fixing regressions introduced in 4.45.2, which we bumped to in #3494.
I've also filed mikefarah/yq#2367 to ask why yq requires Go 1.24 (I don't think it actually does).
There was a problem hiding this comment.
And as far as I know, you even have to depend on "1.24.0" now (since go1.21). None of this fuzzy/friendly
There was a problem hiding this comment.
I've now taken a closer look, and the requirement for 1.24 in yq does come from one of its dependencies: a8m/envsubst#66
This still looks like a misguided use of the go line to force the user to upgrade Go, but I don't think there is any point in following up on this.
I think we should stay with 1.23 until Lima 1.10 is out (and keep yq at 4.45.1 until then), and then consider moving to Go 1.24 afterwards.
There was a problem hiding this comment.
This still looks like a misguided use
You can see the misunderstanding by how in CI they (a8m/envsubst) still test compiling with both 1.23 and 1.24.
This makes no sense because the go 1.24 line will ensure that both jobs are compiled with 1.24.
Bumps [github.com/mikefarah/yq/v4](https://github.com/mikefarah/yq) from 4.45.2 to 4.45.4. - [Release notes](https://github.com/mikefarah/yq/releases) - [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt) - [Commits](mikefarah/yq@v4.45.2...v4.45.4) --- updated-dependencies: - dependency-name: github.com/mikefarah/yq/v4 dependency-version: 4.45.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/mikefarah/yq/v4-4.45.4
branch
from
5657235 to
18dc64b
Compare
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/mikefarah/yq/v4-4.45.4
branch
Bumps github.com/mikefarah/yq/v4 from 4.45.2 to 4.45.4.
Release notes
Sourced from github.com/mikefarah/yq/v4's releases.
Changelog
Sourced from github.com/mikefarah/yq/v4's changelog.
Commits
b534aa9Bumping version39a65b6Updating release notes1e3006eRemoving old issue template22949dfFixing running map against empty array bug #2359734e2cdBumping version082b76aPreparing release notes5bc2cd0Bumping golang version20407a0Adding more tests to prevent regression again :sweat0a83da6Bump github.com/pelletier/go-toml/v2 from 2.2.3 to 2.2.477da8b7Bump golang from 1.24.2 to 1.24.3Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)