Refactor: Remove driver.BaseDriver, move drivers and image-downloader to pkg/driver #3691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant architectural refactoring to the driver implementation in Lima. It is the foundational first part of the larger GSoC project and prepares the codebase for upcoming features by improving modularity and support for external drivers. This PR sets the project structure and refactoring needed for the next three submissions.
Key Changes
driver.BaseDriver
: TheBaseDriver
struct has been removed. Interface functions are implemented directly within the specific drivers.pkg/driver/
directory. This co-locates driver code (e.g.,pkg/qemu
is nowpkg/driver/qemu
).GSoC Context
This is the 1st of 4 PRs that make up my initial GSoC project submission for mid-term evaluations. Merging this foundational PR is a prerequisite for the subsequent three, which will build upon this new architecture.
Related Issues
pkg/{qemu,vz,wsl2}
topkg/driver
#3499BaseDriver
struct #3567