Skip to content

rename UDPEstablished to UDPUnconnected #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Conversation

stek29
Copy link
Contributor

@stek29 stek29 commented Jul 13, 2025

I've spent some time debugging issues with UDP forwarding and got sidetracked because of this constant, so I decieded to submit this PR suggesting to change it

there's no "established" for the UDP, and 0x7 is usually called UNCONN in tools like net-tools or ss

strictly speaking there's no "unconnected" constant in the kernel either, but it's a well known way to call it.

this might be a matter of taste, so please feel free to close this PR if you disagree

@stek29 stek29 force-pushed the patch-1 branch 2 times, most recently from 6acee3a to 861948f Compare July 13, 2025 22:51
@stek29
Copy link
Contributor Author

stek29 commented Jul 13, 2025

the QEMU linux host seems to be flaky, since each time a different port has failed there

on the vz — I'm not sure what exactly the issue is there

@AkihiroSuda AkihiroSuda requested a review from balajiv113 July 14, 2025 07:30
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jul 14, 2025
I've spent some time debugging issues with UDP forwarding and got sidetracked because of this constant, so I decieded to submit this PR suggesting to change it

there's no "established" for the UDP, and 0x7 is usually called UNCONN in tools like net-tools or ss

Signed-off-by: Viktor Oreshkin <[email protected]>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit d7f297a into lima-vm:master Jul 14, 2025
62 of 63 checks passed
@stek29 stek29 deleted the patch-1 branch July 14, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants